Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/date value datepicker #1190

Merged
merged 39 commits into from
Sep 30, 2024

Commits on Sep 13, 2024

  1. feat(datepicker): accepts dateValue as value

    This issue was found in a scenario where I needed to update the selectedDate without clicking into
    the component, just by passing a value to the Datepicker, and actually it just accepts changes by
    clicking which I don't believe covers the use cases.
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6b779a5 View commit details
    Browse the repository at this point in the history
  2. chore(lint/prettier): cleaning code

    Cleaning code
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c114f6e View commit details
    Browse the repository at this point in the history
  3. removed unecessary debug

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9812a4c View commit details
    Browse the repository at this point in the history
  4. test(fixing tests): finding why tests are not running

    Tests stopped running locally, running it on the pipe
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef8d49a View commit details
    Browse the repository at this point in the history
  5. chore: fixed testing for the use case scenario

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f33d2c6 View commit details
    Browse the repository at this point in the history
  6. fix: removing commments

    Comments removal
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1e84357 View commit details
    Browse the repository at this point in the history
  7. chore(reducing complexity for datevalue): assertive state/context man…

    …agement according view/date
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c48f026 View commit details
    Browse the repository at this point in the history
  8. chore: linting

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2f8c02c View commit details
    Browse the repository at this point in the history
  9. feat: added necessary documentation

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e043936 View commit details
    Browse the repository at this point in the history
  10. Update Datepicker.spec.tsx

    chore: removing screen.debug
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    02cd518 View commit details
    Browse the repository at this point in the history
  11. chore: pipeline build fixes

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    25478f0 View commit details
    Browse the repository at this point in the history
  12. fix(clear button): fixed datepicker clear button to not displaying an…

    …y selected date by using null"
    
    Attributed null as a acceptable value to the selectedDate, also removed default args for weekstart
    which was crashing the app due to an overlap with the component props
    
    1039
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    df5968b View commit details
    Browse the repository at this point in the history
  13. Update Datepicker.spec.tsx

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f25bb18 View commit details
    Browse the repository at this point in the history
  14. test(datepicker): clear

    Clear should affect dateValue
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a0b94ba View commit details
    Browse the repository at this point in the history
  15. docs(datepicker): it should have right type for the new empty date ca…

    …se scenario texting property
    
    Updated datepicker component storybook file controls, added the new property and its type so the dev
    can simulate scenarios on storybook
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3dd087b View commit details
    Browse the repository at this point in the history
  16. chore: removing unecessary console

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d8f572c View commit details
    Browse the repository at this point in the history
  17. docs(datepicker): label naming

    Changed the name from labelempty to label
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7a3a85d View commit details
    Browse the repository at this point in the history
  18. feat(datepicker): datevalue expects null to clear date

    Now datevalue expects null to clear date, also a diff mechanism was added on the dateValue useffect
    to prevent mass re-renders.
    
    g
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6c06037 View commit details
    Browse the repository at this point in the history
  19. feat(datepicker): datepicker should expect value and defaultValue

    Now datepicker component accepts value and defaultValue as props comes from this is the most
    intuitive pattern.
    
    BREAKING CHANGE: A breaking change which affects the old property defaultDate being named now
    defaultValue.
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ceb4ccf View commit details
    Browse the repository at this point in the history
  20. feat(datepicker): datepicker default value and sideeffects

    Setting defaultvalue to empty when the component loads, therefore updating its sideffects on
    mounting considering dateview initialization | Added test cases to these scenarios | Added propper
    naming and default values according flowbite patterns
    
    BREAKING CHANGE: New defaultValue initialization value | Migrating from defaultDate to defaultValue
    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    82d5f6a View commit details
    Browse the repository at this point in the history
  21. feat: adding datevalue property

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8f62e4c View commit details
    Browse the repository at this point in the history
  22. feat: handling date value with propper test cases

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a1e915b View commit details
    Browse the repository at this point in the history
  23. feat: handling date value with propper test cases

    ddiasfront authored and Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f66442d View commit details
    Browse the repository at this point in the history
  24. feat: removed default value and renamed onchange prop

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    799f456 View commit details
    Browse the repository at this point in the history
  25. feat: solved comments | updated tests and parameters

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3583b13 View commit details
    Browse the repository at this point in the history
  26. feat: ts compiling

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ac1d098 View commit details
    Browse the repository at this point in the history
  27. feat: added null as a type reference for selectedDate

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6f7f6c6 View commit details
    Browse the repository at this point in the history
  28. feat: prettier

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    628dc14 View commit details
    Browse the repository at this point in the history
  29. feat: added value as a modifier

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1e5a610 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    92a826a View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    c9fb6c1 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    4459adf View commit details
    Browse the repository at this point in the history
  33. feat: format check

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6e477a5 View commit details
    Browse the repository at this point in the history
  34. feat: addressing hook dependencies

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3a62843 View commit details
    Browse the repository at this point in the history
  35. feat: controlled component setup | clearn functionality

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    10f0f56 View commit details
    Browse the repository at this point in the history
  36. feat: remove debugger statement

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7ca4295 View commit details
    Browse the repository at this point in the history
  37. feat: defaultDate empty and side-effects addressed

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4548a0c View commit details
    Browse the repository at this point in the history
  38. feat: added changeset

    Dias, Diego committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dfef19d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. feat - changset to patch

    Dias, Diego committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f082ca7 View commit details
    Browse the repository at this point in the history