-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/date value datepicker #1190
Feat/date value datepicker #1190
Commits on Sep 13, 2024
-
feat(datepicker): accepts dateValue as value
This issue was found in a scenario where I needed to update the selectedDate without clicking into the component, just by passing a value to the Datepicker, and actually it just accepts changes by clicking which I don't believe covers the use cases.
Configuration menu - View commit details
-
Copy full SHA for 6b779a5 - Browse repository at this point
Copy the full SHA 6b779a5View commit details -
chore(lint/prettier): cleaning code
Cleaning code
Configuration menu - View commit details
-
Copy full SHA for c114f6e - Browse repository at this point
Copy the full SHA c114f6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9812a4c - Browse repository at this point
Copy the full SHA 9812a4cView commit details -
test(fixing tests): finding why tests are not running
Tests stopped running locally, running it on the pipe
Configuration menu - View commit details
-
Copy full SHA for ef8d49a - Browse repository at this point
Copy the full SHA ef8d49aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f33d2c6 - Browse repository at this point
Copy the full SHA f33d2c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e84357 - Browse repository at this point
Copy the full SHA 1e84357View commit details -
chore(reducing complexity for datevalue): assertive state/context man…
…agement according view/date
Configuration menu - View commit details
-
Copy full SHA for c48f026 - Browse repository at this point
Copy the full SHA c48f026View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f8c02c - Browse repository at this point
Copy the full SHA 2f8c02cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e043936 - Browse repository at this point
Copy the full SHA e043936View commit details -
chore: removing screen.debug
Configuration menu - View commit details
-
Copy full SHA for 02cd518 - Browse repository at this point
Copy the full SHA 02cd518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25478f0 - Browse repository at this point
Copy the full SHA 25478f0View commit details -
fix(clear button): fixed datepicker clear button to not displaying an…
…y selected date by using null" Attributed null as a acceptable value to the selectedDate, also removed default args for weekstart which was crashing the app due to an overlap with the component props 1039
Configuration menu - View commit details
-
Copy full SHA for df5968b - Browse repository at this point
Copy the full SHA df5968bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f25bb18 - Browse repository at this point
Copy the full SHA f25bb18View commit details -
Clear should affect dateValue
Configuration menu - View commit details
-
Copy full SHA for a0b94ba - Browse repository at this point
Copy the full SHA a0b94baView commit details -
docs(datepicker): it should have right type for the new empty date ca…
…se scenario texting property Updated datepicker component storybook file controls, added the new property and its type so the dev can simulate scenarios on storybook
Configuration menu - View commit details
-
Copy full SHA for 3dd087b - Browse repository at this point
Copy the full SHA 3dd087bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f572c - Browse repository at this point
Copy the full SHA d8f572cView commit details -
docs(datepicker): label naming
Changed the name from labelempty to label
Configuration menu - View commit details
-
Copy full SHA for 7a3a85d - Browse repository at this point
Copy the full SHA 7a3a85dView commit details -
feat(datepicker): datevalue expects null to clear date
Now datevalue expects null to clear date, also a diff mechanism was added on the dateValue useffect to prevent mass re-renders. g
Configuration menu - View commit details
-
Copy full SHA for 6c06037 - Browse repository at this point
Copy the full SHA 6c06037View commit details -
feat(datepicker): datepicker should expect value and defaultValue
Now datepicker component accepts value and defaultValue as props comes from this is the most intuitive pattern. BREAKING CHANGE: A breaking change which affects the old property defaultDate being named now defaultValue.
Configuration menu - View commit details
-
Copy full SHA for ceb4ccf - Browse repository at this point
Copy the full SHA ceb4ccfView commit details -
feat(datepicker): datepicker default value and sideeffects
Setting defaultvalue to empty when the component loads, therefore updating its sideffects on mounting considering dateview initialization | Added test cases to these scenarios | Added propper naming and default values according flowbite patterns BREAKING CHANGE: New defaultValue initialization value | Migrating from defaultDate to defaultValue
Configuration menu - View commit details
-
Copy full SHA for 82d5f6a - Browse repository at this point
Copy the full SHA 82d5f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f62e4c - Browse repository at this point
Copy the full SHA 8f62e4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1e915b - Browse repository at this point
Copy the full SHA a1e915bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66442d - Browse repository at this point
Copy the full SHA f66442dView commit details -
feat: removed default value and renamed onchange prop
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 799f456 - Browse repository at this point
Copy the full SHA 799f456View commit details -
feat: solved comments | updated tests and parameters
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 3583b13 - Browse repository at this point
Copy the full SHA 3583b13View commit details -
Dias, Diego committed
Sep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for ac1d098 - Browse repository at this point
Copy the full SHA ac1d098View commit details -
feat: added null as a type reference for selectedDate
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 6f7f6c6 - Browse repository at this point
Copy the full SHA 6f7f6c6View commit details -
Dias, Diego committed
Sep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 628dc14 - Browse repository at this point
Copy the full SHA 628dc14View commit details -
feat: added value as a modifier
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 1e5a610 - Browse repository at this point
Copy the full SHA 1e5a610View commit details -
feat: updated storybook to reflect controlled and uncontrolled model
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 92a826a - Browse repository at this point
Copy the full SHA 92a826aView commit details -
feat: removed debugger and renamed defaultDate to defaultValue
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for c9fb6c1 - Browse repository at this point
Copy the full SHA c9fb6c1View commit details -
feat: removed debugger and renamed defaultDate to defaultValue
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 4459adf - Browse repository at this point
Copy the full SHA 4459adfView commit details -
Dias, Diego committed
Sep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 6e477a5 - Browse repository at this point
Copy the full SHA 6e477a5View commit details -
feat: addressing hook dependencies
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 3a62843 - Browse repository at this point
Copy the full SHA 3a62843View commit details -
feat: controlled component setup | clearn functionality
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 10f0f56 - Browse repository at this point
Copy the full SHA 10f0f56View commit details -
feat: remove debugger statement
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 7ca4295 - Browse repository at this point
Copy the full SHA 7ca4295View commit details -
feat: defaultDate empty and side-effects addressed
Dias, Diego committedSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 4548a0c - Browse repository at this point
Copy the full SHA 4548a0cView commit details -
Dias, Diego committed
Sep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for dfef19d - Browse repository at this point
Copy the full SHA dfef19dView commit details
Commits on Sep 30, 2024
-
Dias, Diego committed
Sep 30, 2024 Configuration menu - View commit details
-
Copy full SHA for f082ca7 - Browse repository at this point
Copy the full SHA f082ca7View commit details