Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: animation json format preview #2844

Closed
wants to merge 2 commits into from
Closed

WIP: animation json format preview #2844

wants to merge 2 commits into from

Conversation

Jasmine-liang
Copy link
Contributor

@Jasmine-liang Jasmine-liang commented Oct 20, 2022 •
edited
Loading

Here we use react-lottie package as the implementation of animation in json format.
Ref:

@Jasmine-liang Jasmine-liang requested a review from a team as a code owner October 20, 2022 03:05
@vercel
Copy link

vercel bot commented Oct 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
matters-web ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 0:07AM (UTC)

@Jasmine-liang Jasmine-liang marked this pull request as draft October 20, 2022 03:05
@Jasmine-liang Jasmine-liang changed the title WIP: feat(support): animation json format prebview WIP: feat(support): animation json format preview Oct 20, 2022
@Jasmine-liang Jasmine-liang changed the title WIP: feat(support): animation json format preview WIP: animation json format preview Oct 20, 2022
@Jasmine-liang Jasmine-liang linked an issue Oct 20, 2022 that may be closed by this pull request
Animation of support feedback message #2809
Closed
1 task
robertu7
robertu7 suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@robertu7 robertu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can reorg the JSON files and change filenames to English... 01_投幣接飛船?
  • any possible to compress and lazy load the JSON data and library?

@Jasmine-liang
Copy link
Contributor Author

Jasmine-liang commented Oct 24, 2022 •
edited
Loading

Have tried lazy loading methods below:
For lazy loading JSONI data:

For lazy loading library:

@robertu7
Copy link
Contributor

robertu7 commented Nov 7, 2022

implemented in #2868

@robertu7 robertu7 closed this Nov 7, 2022
@Jasmine-liang Jasmine-liang deleted the feat/support-animation branch November 9, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertu7 robertu7 robertu7 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animation of support feedback message
2 participants
@Jasmine-liang @robertu7