-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random carousel review, or ... randousel?! #59
Conversation
Bumps [glob](https://github.com/isaacs/node-glob) from 7.2.0 to 8.0.1. - [Release notes](https://github.com/isaacs/node-glob/releases) - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v7.2.0...v8.0.1) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [d3](https://github.com/d3/d3) from 7.4.3 to 7.4.4. - [Release notes](https://github.com/d3/d3/releases) - [Changelog](https://github.com/d3/d3/blob/main/CHANGES.md) - [Commits](d3/d3@v7.4.3...v7.4.4) --- updated-dependencies: - dependency-name: d3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/d3-7.4.4 Bump d3 from 7.4.3 to 7.4.4
…rn/glob-8.0.1 Bump glob from 7.2.0 to 8.0.1
Bumps [yaml](https://github.com/eemeli/yaml) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: yaml dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) from 3.67.0 to 3.72.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.72.0/clients/client-s3) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/yaml-2.0.1 Bump yaml from 2.0.0 to 2.0.1
…rn/aws-sdk/client-s3-3.72.0 Bump @aws-sdk/client-s3 from 3.67.0 to 3.72.0
Bumps [sass](https://github.com/sass/dart-sass) from 1.50.0 to 1.50.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.50.0...1.50.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/sass-1.50.1 Bump sass from 1.50.0 to 1.50.1
Migrate to esbuild-loader from babel-loader
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.14.36 to 0.14.37. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.14.36...v0.14.37) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) from 3.72.0 to 3.74.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.74.0/clients/client-s3) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [google-auth-library](https://github.com/googleapis/google-auth-library-nodejs) from 7.14.1 to 8.0.0. - [Release notes](https://github.com/googleapis/google-auth-library-nodejs/releases) - [Changelog](https://github.com/googleapis/google-auth-library-nodejs/blob/main/CHANGELOG.md) - [Commits](googleapis/google-auth-library-nodejs@v7.14.1...v8.0.0) --- updated-dependencies: - dependency-name: google-auth-library dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/google-auth-library-8.0.0 Bump google-auth-library from 7.14.1 to 8.0.0
…rn/aws-sdk/client-s3-3.74.0 Bump @aws-sdk/client-s3 from 3.72.0 to 3.74.0
…rn/esbuild-0.14.37 Bump esbuild from 0.14.36 to 0.14.37
Bumps [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) from 3.74.0 to 3.75.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.75.0/clients/client-s3) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.14.37 to 0.14.38. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.14.37...v0.14.38) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/esbuild-0.14.38 Bump esbuild from 0.14.37 to 0.14.38
…rn/aws-sdk/client-s3-3.75.0 Bump @aws-sdk/client-s3 from 3.74.0 to 3.75.0
Bumps [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) from 3.75.0 to 3.76.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.76.0/clients/client-s3) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.13.2 to 1.13.3. - [Release notes](https://github.com/jashkenas/underscore/releases) - [Commits](jashkenas/underscore@1.13.2...1.13.3) --- updated-dependencies: - dependency-name: underscore dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [google-auth-library](https://github.com/googleapis/google-auth-library-nodejs) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/googleapis/google-auth-library-nodejs/releases) - [Changelog](https://github.com/googleapis/google-auth-library-nodejs/blob/main/CHANGELOG.md) - [Commits](googleapis/google-auth-library-nodejs@v8.0.0...v8.0.1) --- updated-dependencies: - dependency-name: google-auth-library dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/google-auth-library-8.0.1 Bump google-auth-library from 8.0.0 to 8.0.1
…rn/underscore-1.13.3 Bump underscore from 1.13.2 to 1.13.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I skipped past the python parts of this and just looked at the graphic component of it, FYI. I think this is the first Svelte thing I've code reviewed, it's neat seeing it in action!
Right now my biggest hangup with this is the text. The longer items feel pretty overwhelming and I find my eyes kind of glazing over -- and on mobile, the scrollbar is hidden by default so it looks like the text just cuts off in the middle of a line. I don't think length is the only issue, though. The kind of dry, legal-ish language used in government reports can really obscure the WTF nature of these items. The user has to really work to understand what's so WTF about them, and I don't know whether users will commit to doing that.
I honestly think these kinds of modules (whether carousel, randousel or just "cards") work best when they have a uniform format and when the text is tightly written/edited to highlight the most salient bits. Writing 51 blurbs is a lot of work, though — does it make sense to cut this down to 10-12 and display them randomly instead of by geolocation?
I think this is a cool take on re-thinking how the carousel works, but it needs some tightening up.
I agree in principle, but given our limited resources, we are experimenting here with just showing whatever they wrote with this one! If it still drives good engagement, maybe it's good enough to skip that level of polish for stories where it's not necessarily needed or we are trying to pick up the pace. |
Hello @Weihua4455! Great work! I have some larger observations/suggestions so figured that would be easier as a standalone comment. Styles
UI/UX
Etc.
|
I just noticed on the preview page that there seem to be some Svelte styles affecting the entire page. I haven't seen this on previous Svelte projects from y'all — are you able to namespace the theme CSS so it doesn't hijack the article page? |
This is coming from |
100% -- this isn't svelte but this component that doesn't feel necessary to me and is going to fight our styles. |
…he place is already a state, closes #68
Track user interaction with Google Analytics
We switched from |
Good afternoon!
We're wrapping up the development of the random carousel for ARPASPENDING, which is basically a card that shows people a CJ-related ARPA spending in their state/district, and goes down the list to show them another one from other states if they click "show me another."
Here's a preview page for the card. We also pulled some texts from the draft and put them in the post, so it can give us a better sense of placement. And here's the story draft.
We're experimenting with the format, and I would love to submit it to a code review. @eads has some edit tickets that he'll write up tonight. In the meantime, please don't hesitate to hit me with design edits/suggestions!
One thing I'd love some help with is setting up trackers to keep track of how/if people interact with the card. I think we can start with tracking the "show me another" button?
Ohh and one more thing: right now we're reading data directly from Airtable through fetching. We'll disable that when we launch & import static data instead.
Thank you SOOOO much for reviewing this and for giving some really valuable advice before we developed it. We're planning to publish this next week, though exact timing is still a bit in the air.