Update @font-face declarations in CSS style sheets #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step for consistency, before upgrading the @font-face declaration.
1) I added the part -sans were missing to ensure that the full name of the family was used as prefix: 'ostrich-sans-' 2) I added the suffix -webfont 3) I removed the suffix -regular which was ambiguous in the context of font style (regular vs italic) and weight (regular vs thin, bold, ...)
For the files "ostrich-sans-inline-webfont.svg" and "ostrich-sans-inline-italic-webfont.svg", which are not in SVG format actually (see issue #7 on GitHub), I replaced the ID with #MISSING for the time being.
The format used for the @font-face declarations is now the "Fontspring @font-face Syntax"[1] considered [2] "the most simple and compatible one". Note: I changed the font-weight declaration for 'Ostrich Sans' Medium from 400 (Normal) to 500 (Medium). [3] [1] The New Bulletproof @font-face Syntax 2011-02-03 (last updated: 2011-04-21) http://www.fontspring.com/blog/the-new-bulletproof-font-face-syntax [2] The @font-face Rule And Useful Web Font Tricks 2011-03-02, by Ralf Hermann http://www.smashingmagazine.com/2011/03/02/the-font-face-rule-revisited-and-useful-tricks/ [3] §3.2. Font weight: the font-weight property in CSS Fonts Module Level 3 http://www.w3.org/TR/css-fonts-3/#font-weight-prop
An extra line was added in February 2011 to account for IE9 rendering a page in compatibility mode for IE7 or IE8. This extra line is still found today (2013) in the CSS of Web font kits downloaded from Font Squirrel and Fontspring.
|
I'm sorry this didn't get reviewed a long time ago, but I'm afraid it's rather obsolete now. In current builds (see recent releases of Raleway, League Spartan, League Gothic, and League Mono) we're not including CSS snippets at all. This will land for this font as well after #16 is ready. If that were to change, the change should happen in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format used for the @font-face declarations is now
the "Fontspring @font-face Syntax"[1] considered [2]
"the most simple and compatible one".
[1] The New Bulletproof @font-face Syntax
2011-02-03 (last updated: 2011-04-21)
http://www.fontspring.com/blog/the-new-bulletproof-font-face-syntax
[2] The @font-face Rule And Useful Web Font Tricks
2011-03-02, by Ralf Hermann
http://www.smashingmagazine.com/2011/03/02/the-font-face-rule-revisited-and-useful-tricks/