[pre-commit.ci] pre-commit autoupdate #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
f286b1f to
6807d2a
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
2 times, most recently
from
43b12b5 to
3f48e2b
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
3f48e2b to
253bcb3
Compare
updates: - [github.com/pre-commit/mirrors-mypy: v1.13.0 → v1.14.0](pre-commit/mirrors-mypy@v1.13.0...v1.14.0) - [github.com/asottile/pyupgrade: v3.19.0 → v3.19.1](asottile/pyupgrade@v3.19.0...v3.19.1) - [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.4](astral-sh/ruff-pre-commit@v0.7.2...v0.8.4)
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
253bcb3 to
18fb149
Compare
added 2 commits
January 2, 2025 20:16
MUCDK
reviewed
Jan 2, 2025
| @@ -353,7 +353,7 @@ def transport_matrix(self) -> ArrayLike: # noqa: D102 | |||
| return self._transport_matrix | |||
|
|
|||
| @property | |||
| def shape(self) -> tuple[int, int]: # noqa: D102 | |||
| def shape(self) -> tuple[int, ...]: # noqa: D102 | |||
There was a problem hiding this comment.
this should not be necessary as ndim ==2.
There was a problem hiding this comment.
because np.shape return type is tuple[int, ...] so it triggers a mypy error even though ndim ==2
MUCDK
reviewed
Jan 2, 2025
| @@ -161,7 +161,7 @@ def from_adata( | |||
| return cls(data_src=data, tag=tag, cost=cost_fn) | |||
|
|
|||
| @property | |||
| def shape(self) -> Tuple[int, int]: | |||
| def shape(self) -> Tuple[int, ...]: | |||
There was a problem hiding this comment.
again, I wonder why this is necessary
MUCDK
reviewed
Jan 2, 2025
| @@ -216,7 +216,7 @@ def _create_graph_geometry( | |||
| problem_shape = x.shape if problem_shape is None else problem_shape | |||
| return _instantiate_geodesic_cost( | |||
| arr=arr, | |||
| problem_shape=problem_shape, | |||
| problem_shape=problem_shape, # type: ignore[arg-type] | |||
There was a problem hiding this comment.
can you please look at why this is necessary?
There was a problem hiding this comment.
the None case is handled before the return but triggers a mypy arg-type error
MUCDK
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: