Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update notebooks #714

Merged
merged 2 commits into from
Jun 14, 2024
Merged

update notebooks #714

merged 2 commits into from
Jun 14, 2024

Conversation

ArinaDanilina
Copy link
Collaborator

No description provided.

@ArinaDanilina ArinaDanilina requested a review from MUCDK June 13, 2024 16:28
MUCDK
MUCDK approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if tests pass obv.

@ArinaDanilina ArinaDanilina merged commit 1277665 into main Jun 14, 2024
8 checks passed
@ArinaDanilina ArinaDanilina deleted the update_notebooks branch June 14, 2024 08:39
@selmanozleyen
Copy link
Collaborator

selmanozleyen commented Jun 14, 2024 •
edited
Loading

Hi @ArinaDanilina I want to note that although the tests passes here it doesnt on the other PR here https://github.com/theislab/moscot/actions/runs/9513260069/job/26222972253#step:5:153 It's just one notebook remaining. Saying so that you won't also have to fix again in the future

@selmanozleyen selmanozleyen mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MUCDK MUCDK MUCDK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArinaDanilina @selmanozleyen @MUCDK