Error/Warning for incompatible terms with solvers #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7457fbf.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 78.19% 77.99% -0.20%
==========================================
Files 36 36
Lines 3806 3818 +12
Branches 706 712 +6
==========================================
+ Hits 2976 2978 +2
- Misses 524 529 +5
- Partials 306 311 +5
|
MUCDK
reviewed
Apr 9, 2024
| @@ -105,7 +104,7 @@ def test_solve_balanced( | |||
|
|
|||
| tp = TranslationProblem(adata_src, adata_tgt) | |||
| tp = tp.prepare(batch_key="batch", src_attr=src_attr, tgt_attr=tgt_attr) | |||
| tp = tp.solve(epsilon=epsilon, alpha=alpha, rank=rank, **kwargs) | |||
| tp = tp.solve(epsilon=epsilon, rank=rank, **kwargs) | |||
There was a problem hiding this comment.
please include a test where you explicitly have a fused term, too.
MUCDK
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #680.
After adding tests to assert that errors are thrown it should be done.