Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assert for index/column names when comparing series (e.g. in set_x, set_y, and set_x) #669

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

selmanozleyen
Copy link
Collaborator

Fixes #668. To standardize series assertions I used an utility function in all cases where pd.testing.assert_equal_series is used.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.19%. Comparing base (939e91b) to head (a686d00).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files          36       36           
  Lines        3806     3806           
  Branches      706      706           
=======================================
  Hits         2976     2976           
  Misses        524      524           
  Partials      306      306           
Files Coverage Δ
src/moscot/base/problems/_utils.py 64.03% <100.00%> (+0.57%) ⬆️
src/moscot/base/problems/problem.py 77.50% <84.61%> (-0.31%) ⬇️

@giovp giovp requested review from giovp and MUCDK March 26, 2024 08:25
Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@MUCDK MUCDK merged commit 3151da7 into main Apr 2, 2024
9 checks passed
@MUCDK MUCDK deleted the fix/set_x_assertion branch April 2, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_x adapt assertion
3 participants