Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test example in CI (new) #579

Merged
merged 39 commits into from
Mar 26, 2024
Merged

test example in CI (new) #579

merged 39 commits into from
Mar 26, 2024

Conversation

ArinaDanilina
Copy link
Collaborator

@ArinaDanilina ArinaDanilina linked an issue Jul 15, 2023 that may be closed by this pull request
@MUCDK
Copy link
Collaborator

MUCDK commented Dec 17, 2023

@giovp @ArinaDanilina what's the state here?

@giovp
Copy link
Member

giovp commented Mar 5, 2024

super cool @selmanozleyen , just fyi I think it's fine to just run for now notebooks in the example folder. Looking forward to updates!

@selmanozleyen
Copy link
Collaborator

selmanozleyen commented Mar 7, 2024

thanks @giovp, current setup should be a functional example. Some notebooks do give errors.

First,I tried to do it the way @michalk8 suggested here #552 (comment) (by building docs) but it required messing with the metadata of nb files and the errors were written to log files. For now jupytext seemed easier.

update: I have no idea why other tests also fail now, the changes shouldn't have an effect on them

@giovp
Copy link
Member

giovp commented Mar 7, 2024

I think it's a jax update https://jax.readthedocs.io/en/latest/changelog.html , I think we need to pin down jax for the time being until ott-jax supports it, cc @MUCDK @michalk8

regarding notebook, which ones are failing? maybe @ArinaDanilina can you take a look, it's probably easy fixes

@MUCDK
Copy link
Collaborator

MUCDK commented Mar 8, 2024

Isn't the example failing according to the tests?

@MUCDK
Copy link
Collaborator

MUCDK commented Mar 8, 2024

@ArinaDanilina can you check the failing example, please?

@giovp
Copy link
Member

giovp commented Mar 12, 2024

thanks @ArinaDanilina , @selmanozleyen , still some issues in notebooks, but should be easy fix!

@giovp giovp merged commit d79c18c into main Mar 26, 2024
9 checks passed
@giovp giovp deleted the add/test_tutorials_ci branch March 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run tutorials in CI
4 participants