-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test example in CI (new) #579
Conversation
@giovp @ArinaDanilina what's the state here? |
super cool @selmanozleyen , just fyi I think it's fine to just run for now notebooks in the example folder. Looking forward to updates! |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
thanks @giovp, current setup should be a functional example. Some notebooks do give errors. First,I tried to do it the way @michalk8 suggested here #552 (comment) (by building docs) but it required messing with the metadata of nb files and the errors were written to log files. For now jupytext seemed easier. update: I have no idea why other tests also fail now, the changes shouldn't have an effect on them |
I think it's a jax update https://jax.readthedocs.io/en/latest/changelog.html , I think we need to pin down jax for the time being until ott-jax supports it, cc @MUCDK @michalk8 regarding notebook, which ones are failing? maybe @ArinaDanilina can you take a look, it's probably easy fixes |
Isn't the example failing according to the tests? |
@ArinaDanilina can you check the failing example, please? |
thanks @ArinaDanilina , @selmanozleyen , still some issues in notebooks, but should be easy fix! |
#552