Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitessce config generator #40

Merged
merged 26 commits into from
Oct 10, 2024
Merged

Vitessce config generator #40

merged 26 commits into from
Oct 10, 2024

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Oct 9, 2024

@flying-sheep flying-sheep marked this pull request as ready for review October 9, 2024 10:28
@flying-sheep flying-sheep requested a review from eroell October 9, 2024 10:31
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.48%. Comparing base (4160406) to head (59da27f).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/ehrdata/pl/vitessce.py 80.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #40       +/-   ##
===========================================
+ Coverage   15.36%   34.48%   +19.11%     
===========================================
  Files          12       18        +6     
  Lines         501      635      +134     
===========================================
+ Hits           77      219      +142     
+ Misses        424      416        -8     
Files with missing lines Coverage Δ
src/ehrdata/pl/__init__.py 100.00% <100.00%> (ø)
src/ehrdata/pl/vitessce.py 80.00% <80.00%> (ø)

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Oct 10, 2024

OK, finally done.

Tests are slow, because the newest published generate-tiff-offsets depends on a pinned version of tifffile. Newer versions of scikit-image want newer tifffile versions, so the dependency resolver needs to backtrack until it finds scikit-image 0.21 or so, which is slow.

It’s fixed on main (hms-dbmi/generate-tiff-offsets#6), @ilan-gold is on it (pypi/support#4878) and will release a new generate-tiff-offsets version soonish

@flying-sheep flying-sheep requested a review from eroell October 10, 2024 09:47
Copy link
Collaborator

@eroell eroell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this works on the latest notebooks where we demonstrate this as it should.
Thanks!

@eroell eroell merged commit 932d2d6 into main Oct 10, 2024
6 checks passed
@eroell eroell deleted the vitessce-config-gen branch October 10, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants