-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitessce config generator #40
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
===========================================
+ Coverage 15.36% 34.48% +19.11%
===========================================
Files 12 18 +6
Lines 501 635 +134
===========================================
+ Hits 77 219 +142
+ Misses 424 416 -8
|
OK, finally done. Tests are slow, because the newest published generate-tiff-offsets depends on a pinned version of tifffile. Newer versions of scikit-image want newer tifffile versions, so the dependency resolver needs to backtrack until it finds scikit-image 0.21 or so, which is slow. It’s fixed on main (hms-dbmi/generate-tiff-offsets#6), @ilan-gold is on it (pypi/support#4878) and will release a new generate-tiff-offsets version soonish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this works on the latest notebooks where we demonstrate this as it should.
Thanks!
Fixes https://github.com/theislab/ehrdata-datasets/issues/10
Rendered docs