Fix typo in Contributing.md #820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zethson
reviewed
Nov 6, 2024
| @@ -51,7 +51,7 @@ and [prettier][prettier-editors]. | |||
| ## Writing tests | |||
|
|
|||
| ```{note} | |||
| Remember to first install the package with `pip install '-e[dev,test]'` | |||
| Remember to first install the package with `pip install -e "[dev,test,docs]"` | |||
tests/plot/test_catplot.py
Outdated
| @@ -11,6 +11,6 @@ def test_catplot_vanilla(adata_mini, check_same_image): | |||
|
|
|||
| check_same_image( | |||
| fig=fig, | |||
| base_path=f"{_TEST_IMAGE_PATH}/catplot_vanilla", | |||
| base_path=f"{_TEST_IMAGE_PATH}/catplot_vanilla",; | |||
There was a problem hiding this comment.
I asked @aGuyLearning to make something fail to see how the CI flares up :)
|
Run Notebooks test seems to fail, when changes are not made in ehrapy repo? |
|
I think that's because a Github permission error. Can you recreate this PR without your fork but now by just branching from this repository, please? You are now a collaborator. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819