Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/restrict tableone #754

Merged
merged 20 commits into from
Jul 17, 2024
Merged

Fix/restrict tableone #754

merged 20 commits into from
Jul 17, 2024

Conversation

eroell
Copy link
Collaborator

@eroell eroell commented Jun 16, 2024

PR Checklist

Description of changes
Loosen restriction to tableone!=0.9.0, that is allowing the bug fix release 0.9.1, and future versions.

Technical details
Instead of being stuck at 0.8.0, anything != 0.9.0 will be fine.

Additional context
See tableone issue here.

@github-actions github-actions bot added the bug Something isn't working label Jun 16, 2024
@eroell
Copy link
Collaborator Author

eroell commented Jun 16, 2024

Seems tableone>0.8.0 breaks the readthedocs build. 0.8.0 works fine.
Figure out why and resolve later.

@eroell eroell marked this pull request as ready for review July 11, 2024 17:11
@eroell
Copy link
Collaborator Author

eroell commented Jul 17, 2024

rtd built worked with tableone 0.9.1 👍

@eroell eroell merged commit 0d3fd66 into main Jul 17, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tableone release 0.9.0 raises error on a common usecase for us
1 participant