Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional salutations and custom addition method #45

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jamessampford
Copy link

@jamessampford jamessampford commented May 16, 2020

Added a few extra salutations as per #42 and also provided some additional methods to add custom salutations in that do not already exist

I was wondering if perhaps some salutations could be standardised - I've added a few examples into the list [Professor => Prof; Reverend => Rev; Pastor => Pr]

Additional ones could potentially pick up Doctor and transform it to Dr, Father to Fr, etc

@coveralls
Copy link

coveralls commented May 16, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 600cd0c on jamessampford:master into 8da40c7 on theiconic:master.

Copy link
Contributor

@wyrfel wyrfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jamessampford . Thanks for this PR. I would like to merge the added salutations, but not the custom salutation methods. The reasoning is that the NameParser already allows the passing of several custom language extension classes. You should really use that mechanism instead. It is also much more flexible as those custom classes can e.g. source the definitions from configuration files, data stores etc. .

eileenmcnaughton added a commit to eileenmcnaughton/name-parser that referenced this pull request Mar 2, 2024
This picks up from
theiconic#54
and theiconic#45
but only the additional prefixes & suffixes - not the logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants