Merge pull request #20 from theiconic/feature/add-tests-for-vietnames…

…e-names Add unit tests to verify parsing and normalisation of vietnamese names
theiconic · Jun 3, 2019 · c6721fc · c6721fc
2 parents dbffe73 + 1e791cc
commit c6721fc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/src/Name.php b/src/Name.php
@@ -173,7 +173,7 @@ public function getMiddlename(): string
      * helper method used by getters to extract and format relevant name parts
      *
      * @param string $type
-     * @param bool $pure
+     * @param bool $strict
      * @return string
      */
     protected function export(string $type, bool $strict = false): string

diff --git a/src/Part/AbstractPart.php b/src/Part/AbstractPart.php
@@ -82,7 +82,7 @@ protected function camelcase($word): string
     protected function camelcaseReplace($matches): string
     {
         if (function_exists('mb_convert_case')) {
-            return mb_convert_case($matches[0], MB_CASE_TITLE, "UTF-8");
+            return mb_convert_case($matches[0], MB_CASE_TITLE, 'UTF-8');
         }
 
         return ucfirst(strtolower($matches[0]));

diff --git a/tests/ParserTest.php b/tests/ParserTest.php
@@ -487,6 +487,14 @@ public function provider()
                     'initials' => 'M.',
                     'suffix' => 'Jr',
                 ]
+            ],
+            [
+                'Thái Quốc Nguyễn',
+                [
+                    'lastname' => 'Nguyễn',
+                    'middlename' => 'Quốc',
+                    'firstname' => 'Thái',
+                ]
             ]
         ];
     }

diff --git a/tests/Part/NormalisationTest.php b/tests/Part/NormalisationTest.php
@@ -30,6 +30,12 @@ public function testCamelcasingWorksWithMbString()
 
         $part = new Firstname('etna');
         $this->assertEquals('Etna', $part->normalize());
+
+        $part = new Firstname('thái');
+        $this->assertEquals('Thái', $part->normalize());
+
+        $part = new Lastname('nguyễn');
+        $this->assertEquals('Nguyễn', $part->normalize());
    }
 
     /**