Skip to content

Commit

Permalink
changes based on discussion
Browse files Browse the repository at this point in the history
  • Loading branch information
thehesiod committed Nov 12, 2018
1 parent ee5eec2 commit 72396ea
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
17 changes: 16 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ load(
java_appengine_repositories()

# Python
load(
"@io_bazel_rules_appengine//appengine:sdk.bzl",
"appengine_repositories",
)

appengine_repositories()

load(
"@io_bazel_rules_appengine//appengine:py_appengine.bzl",
"py_appengine_repositories",
Expand Down Expand Up @@ -334,7 +341,7 @@ java_war(name, data, data_path, **kwargs)
<a name="py_appengine_binary"></a>
## py_appengine_binary
```python
py_appengine_binary(name, srcs, configs, deps=[], data=[])
py_appengine_binary(name, srcs, configs, deps=[], data=[], overwrite_appengine_config=True)
```
<table class="table table-condensed table-bordered table-params">
<colgroup>
Expand Down Expand Up @@ -382,6 +389,14 @@ py_appengine_binary(name, srcs, configs, deps=[], data=[])
<p>List of files used by the Web Application at runtime.</p>
</td>
</tr>
<tr>
<td><code>overwrite_appengine_config</code></td>
<td>
<code>Boolean, optional</code>
<p>If true, patch the user's appengine_config into the base one. If false, use
the user specified config directly. Set to False to behave pre 0.0.8.</p>
</td>
</tr>
</tbody>
</table>

Expand Down
6 changes: 5 additions & 1 deletion appengine/py/appengine_deploy.sh.template
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ if [[ -e "$self.runfiles/%{workspace_name}" ]]; then
fi

ROOT=$PWD
tmp_dir="$(mktemp -d "${TMPDIR:-/tmp}/war.XXXXXXXX")"

# remove double slash from TMPDIR trailing slash
tmp_dir=$(echo ${TMPDIR:-/tmp}/war.XXXXXXXX | tr -s /)
tmp_dir="$(mktemp -d "${tmp_dir}")"

cp -R $ROOT $tmp_dir
trap "{ cd "$ROOT"; rm -rf "$tmp_dir"; }" EXIT

Expand Down

0 comments on commit 72396ea

Please sign in to comment.