add perception validator + summary detail validations

thegreenter · Jan 24, 2018 · e08c574 · e08c574
1 parent d1680c0
commit e08c574
Show file tree

Hide file tree

Showing 8 changed files with 67 additions and 64 deletions.
diff --git a/README.md b/README.md
@@ -4,8 +4,8 @@
  [![Codacy Badge](https://api.codacy.com/project/badge/Grade/b237d274d88d47fbab43ddac252d73a9)](https://www.codacy.com/app/giansalex/greenter-validator?utm_source=github.com&amp;utm_medium=referral&amp;utm_content=giansalex/greenter-validator&amp;utm_campaign=Badge_Grade)    
 Symfony Validator for [Greenter](https://github.com/giansalex/greenter)
 
-## Composer
-
+## Install
+Using composer from [packagist.org](https://packagist.org/packages/greenter/validator)
 ```bash
 composer require greenter/validator
 ```

diff --git a/src/Validator/Loader/InvoiceLoader.php b/src/Validator/Loader/InvoiceLoader.php
@@ -35,6 +35,7 @@ public function load(ClassMetadata $metadata)
             new Assert\NotBlank(),
             new Assert\Date(),
         ]);
+        $metadata->addPropertyConstraint('fecVencimiento', new Assert\Date());
         $metadata->addPropertyConstraints('tipoMoneda', [
             new Assert\NotBlank(),
             new Assert\Length(['max' => 3]),

diff --git a/src/Validator/Loader/NoteLoader.php b/src/Validator/Loader/NoteLoader.php
@@ -65,6 +65,7 @@ public function load(ClassMetadata $metadata)
         ]);
         $metadata->addPropertyConstraint('details', new Assert\Valid());
         $metadata->addPropertyConstraint('legends', new Assert\Valid());
+        $metadata->addPropertyConstraint('guias', new Assert\Valid());
         $metadata->addPropertyConstraint('relDocs', new Assert\Valid());
         $metadata->addPropertyConstraint('perception', new Assert\Valid());
         $metadata->addPropertyConstraints('codMotivo', [

diff --git a/src/Validator/Loader/SalePerceptionLoader.php b/src/Validator/Loader/SalePerceptionLoader.php
@@ -18,9 +18,8 @@ public function load(ClassMetadata $metadata)
     {
         $metadata->addPropertyConstraints('codReg', [
             new Assert\NotBlank(),
-            new Assert\Length([
-                'min' => 2,
-                'max' => 2,
+            new Assert\Choice([
+                'choices' => ['01', '02', '03'],
             ]),
         ]);
 //        $metadata->addPropertyConstraint('tasa', new Assert\NotBlank());

diff --git a/src/Validator/Loader/SummaryDetailLoader.php b/src/Validator/Loader/SummaryDetailLoader.php
@@ -21,14 +21,7 @@ public function load(ClassMetadata $metadata)
         $metadata->addPropertyConstraints('tipoDoc', [
             new Assert\NotBlank(),
             new Assert\Choice([
-                'choices' => ['03', '07', '08'],
-            ]),
-        ]);
-        $metadata->addPropertyConstraints('serieNro', [
-            new Assert\NotBlank(),
-            new Assert\Regex([
-                'pattern' => '/^[B][A-Z0-9]{3}-[0-9]{1,8}$/',
-                'message' => 'La serie no cumple el formato BXXX',
+                'choices' => ['03', '07', '08', '12'],
             ]),
         ]);
         $metadata->addPropertyConstraints('clienteTipo', [
@@ -48,11 +41,32 @@ public function load(ClassMetadata $metadata)
             ]),
         ]);
         $metadata->addPropertyConstraint('docReferencia', new Assert\Valid());
+        $metadata->addPropertyConstraint('percepcion', new Assert\Valid());
         $metadata->addPropertyConstraint('total', new Assert\NotBlank());
         $metadata->addPropertyConstraint('mtoIGV', new Assert\NotBlank());
 
         $callback = function ($object, ExecutionContextInterface $context) {
             /** @var $object SummaryDetail */
+            $pattern = $object->getTipoDoc() == '12' ? "/^[a-zA-Z0-9]{1,20}(-[0-9]{1,20})$/" : "/^[B][A-Z0-9]{3}-[0-9]{1,8}$/";
+            if (!preg_match($pattern, $object->getSerieNro())) {
+                $context->buildViolation('Nro de documento no cumple con el formato para tipo doc. '.$object->getTipoDoc())
+                    ->atPath('serieNro')
+                    ->addViolation();
+            }
+
+            if ($object->getTipoDoc() == '07' || $object->getTipoDoc() == '08') {
+                if (empty($object->getDocReferencia())) {
+                    $context->buildViolation('Necesita un documento de referencia para tipo doc. '.$object->getTipoDoc())
+                        ->atPath('docReferencia')
+                        ->addViolation();
+                } else if (!in_array($object->getDocReferencia()->getTipoDoc(), ['03', '12'])) {
+                    $context->buildViolation('Documento de referencia solo puede ser Ticket(12) o Boleta(03)')
+                        ->atPath('docReferencia')
+                        ->addViolation();
+                }
+
+            }
+
             if (!($object->getTotal() > 750)) {
                 return;
             }

diff --git a/src/Validator/Loader/SummaryDetailV2Loader.php b/src/Validator/Loader/SummaryDetailV2Loader.php
diff --git a/src/Validator/Loader/SummaryPerceptionLoader.php b/src/Validator/Loader/SummaryPerceptionLoader.php
@@ -0,0 +1,33 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: Administrador
+ * Date: 24/01/2018
+ * Time: 11:34 AM
+ */
+
+namespace Greenter\Validator\Loader;
+
+use Greenter\Validator\LoaderMetadataInterface;
+use Symfony\Component\Validator\Mapping\ClassMetadata;
+use Symfony\Component\Validator\Constraints as Assert;
+
+/**
+ * Class SummaryPerceptionLoader
+ */
+class SummaryPerceptionLoader implements LoaderMetadataInterface
+{
+    public function load(ClassMetadata $metadata)
+    {
+        $metadata->addPropertyConstraints('codReg', [
+            new Assert\NotBlank(),
+            new Assert\Choice([
+                'choices' => ['01', '02', '03'],
+            ]),
+        ]);
+        $metadata->addPropertyConstraint('tasa', new Assert\NotBlank());
+        $metadata->addPropertyConstraint('mtoBase', new Assert\NotBlank());
+        $metadata->addPropertyConstraint('mto', new Assert\NotBlank());
+        $metadata->addPropertyConstraint('mtoTotal', new Assert\NotBlank());
+    }
+}
diff --git a/tests/Validator/FeInvoiceValidatorTest.php b/tests/Validator/FeInvoiceValidatorTest.php
@@ -55,15 +55,13 @@ private function getInvoice()
             ->setSumDsctoGlobal(12)
             ->setMtoDescuentos(23)
             ->setTipoOperacion('2')
+            ->setFecVencimiento(new \DateTime())
             ->setPerception((new SalePerception())
                 ->setCodReg('01')
                 ->setMto(2)
                 ->setMtoBase(3)
                 ->setMtoTotal(4)
-            )->setGuias([(new Document())
-                ->setTipoDoc('09')
-                ->setNroDoc('T001-1')
-            ])->setCompra('001-12112')
+            )->setCompra('001-12112')
             ->setDetraccion((new Detraction())
                 ->setMount(2228.3)
                 ->setPercent(9)
@@ -94,6 +92,10 @@ private function getInvoice()
                 ->setTipoDoc('01')
                 ->setNroDoc('F001-123')
             ])
+            ->setGuias([(new Document())
+                ->setTipoDoc('09')
+                ->setNroDoc('T001-1')
+            ])
             ->setTipoDoc('01')
             ->setSerie('F001')
             ->setCorrelativo('123')