Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor out one off page templates to top level pages and components #215

Merged
merged 3 commits into from
Jun 5, 2021
Merged

refactor out one off page templates to top level pages and components #215

merged 3 commits into from
Jun 5, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 30, 2021 •
edited
Loading

Related Issue

resolves #188

Summary of Changes

  1. Refactored out logic from one off page templates to be in their own components
  2. Refactored out one off page templates to be in their own top level pages

TODO

  1. Need upstream related changes merged and released for this to work as expected - Enhancement/issue 435 deeply nested relative paths ProjectEvergreen/greenwood#618

@thescientist13 thescientist13 added the chore build stuff, deploy stuff, etc etc label May 30, 2021
@thescientist13 thescientist13 self-assigned this May 30, 2021
@thescientist13 thescientist13 force-pushed the chore/issue-188-refactor-page-templates-to-top-level branch from 6d16616 to 8c222ec Compare May 30, 2021 19:04
@thescientist13 thescientist13 changed the title factor out one off page templates to top level pages and components refactor out one off page templates to top level pages and components May 30, 2021
@thescientist13 thescientist13 mentioned this pull request May 30, 2021
Merged
8 tasks
@thescientist13 thescientist13 added the needs upstream Dependent on work / features from Greenwood label May 30, 2021
@thescientist13 thescientist13 marked this pull request as ready for review June 5, 2021 16:35
@thescientist13 thescientist13 merged commit 67e7b71 into master Jun 5, 2021
@thescientist13 thescientist13 deleted the chore/issue-188-refactor-page-templates-to-top-level branch June 5, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore build stuff, deploy stuff, etc etc needs upstream Dependent on work / features from Greenwood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor post template to use blog post details directly from template
1 participant
@thescientist13