DEV-16772: Fix quire-figure.webc styles
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderspollack
commented
Jan 30, 2024
| .quire-grid--2 { | ||
| width: 49%; | ||
| .quire-grid--2 > * { | ||
| width: 50%; |
There was a problem hiding this comment.
@geealbers I had to change where we were applying the .quire-grid--# classes, and the starter only has an instance of a 2 column grid. These percentages seem to be set intentionally slightly lower than the intended amount (49% vs 50% here). I had to adjust it back to 50% to match.
I think the DOM changes in thegetty/quire#893 might have unintentionally fixed a thing that was requiring these weird percentages, but I am going to hold off on adjusting the other column counts until we have testbed examples of figureGroups with all possible column counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update styles to correspond with thegetty/quire#893
Note: This should not be merged until after above PR has been merged +
latestquire-11typackage has been updated with the PR contents