Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Paged.js Documentation #664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fchasen
Copy link

@fchasen fchasen commented May 16, 2023

Adds documentation for using Paged.js with Quire and links to Paged Media resources.

Checklist

Please put an X within the brackets that apply [X].

  • I have read the CONTRIBUTING.md file.

  • I have made my changes in a new branch and not directly in the main branch

  • I am requesting feedback on a draft pull request

Comment on lines +51 to +81
```css
// WORKS
@page {
size: A5
@bottom-left {
content: counter(page);
}
}

@page cover {
background-color: purple;
@bottom-left {
content: counter(page);
}
}

// FAILS
@page {
size: A5
}

@page cover {
background-color: purple;
}

@page, @page cover {
@bottom-left {
content: counter(page);
}
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make the example more clear to separate and order the examples fails and works, thoughts?

Suggested change
```css
// WORKS
@page {
size: A5
@bottom-left {
content: counter(page);
}
}
@page cover {
background-color: purple;
@bottom-left {
content: counter(page);
}
}
// FAILS
@page {
size: A5
}
@page cover {
background-color: purple;
}
@page, @page cover {
@bottom-left {
content: counter(page);
}
}
```
*FAILS*

@page {
size: A5
}

@page cover {
background-color: purple;
}

@page, @page cover {
@bottom-left {
content: counter(page);
}
}


*WORKS*
```css
@page {
	size: A5
	@bottom-left {
  		content: counter(page);
	}
}

@page cover {
	background-color: purple;
	@bottom-left {
  		content: counter(page);
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants