Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit/#470/Fix-typo #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

materiajournal
Copy link

Fixed typo of missing "t" in the word "institution" in data>projects.yml>line163

Thank you for contributing to the Quire Documentation & Website! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Edit, Add, Translate. Issue-# is only needed if this pull request addresses an existing issue.

Checklist

Please put an X within the brackets that apply [X].

  • [ x] I have read the CONTRIBUTING.md file.

  • [x ] I have made my changes in a new branch and not directly in the main branch

  • I am requesting feedback on a draft pull request

Is this pull request related to an open issue? If so, what is the issue number?

#470

Please describe the goal of this pull request and the changes that were made.

Fix typo

Additional Comments

Fixed typo of missing "t" in the word "institution" in data>projects.yml>line163
@Erin-Cecele
Copy link
Collaborator

Hi @materiajournal. This looks great!! Thank you for correcting the spelling of "institutions." @vyn2000 did originally express interest in working on this issue, but I have not heard from them in quite some time so I think it's ok that you went ahead with it.

In fact, if you look at my conversation with vyn, you'll notice that I also requested an edit to the content of that sentence (beyond just fixing the typo.) Would you mind making that correction as well? Thank you!!

@Erin-Cecele
Copy link
Collaborator

Hi @materiajournal, did you want to finish this pull request based on my notes in issue #470?

If you scroll down to line 163, it would actually be most helpful if you could replace all the text that follows note: with the following:

This publication marks the first-ever born-digital, open-access version of the century-old reference series. It uses a version of the default Quire theme that was modified to match the print format CVA volumes have followed since the series was started over a century ago. Hopefully, other institutions might use it down the road for their own CVA volumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants