Update Dockerfile for get-params to use EL9 #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffin-Sullivan
commented
Jun 7, 2024
scripts/installer/Dockerfile
Outdated
|
|
||
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/puppet7-release-el-8.noarch.rpm | ||
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/el/9/x86_64/puppet7-release-7.0.0-19.el9.noarch.rpm |
There was a problem hiding this comment.
I couldn't find a puppet7-release-el-9.noarch.rpm so I just used this one. Probably not best to hard code a specific version like this.
There was a problem hiding this comment.
Suggested change
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/el/9/x86_64/puppet7-release-7.0.0-19.el9.noarch.rpm | |
| RUN dnf -y install https://yum.puppet.com/puppet7-release-el-9.noarch.rpm |
evgeni
reviewed
Jun 11, 2024
scripts/installer/Dockerfile
Outdated
|
|
||
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/puppet7-release-el-8.noarch.rpm | ||
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/el/9/x86_64/puppet7-release-7.0.0-19.el9.noarch.rpm |
There was a problem hiding this comment.
Suggested change
| RUN dnf -y install https://yum.puppetlabs.com/puppet7/el/9/x86_64/puppet7-release-7.0.0-19.el9.noarch.rpm | |
| RUN dnf -y install https://yum.puppetlabs.com/puppet7-release-el-9.noarch.rpm |
at some point they fucked up the puppetX folders and never updated the release symlinks in there 🤷♀️
Griffin-Sullivan
force-pushed
the
install-el8-update
branch
from
26af5f4
to
2c972e0
Compare
evgeni
approved these changes
Jun 12, 2024
ekohl
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS stream 8 is no longer available so we should update this to EL9.