Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Salt plugin page to include all content #2127

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 14, 2024

It's suprising to have the 14.0 documentation have the general information. This makes the landing page contain all the information and redirects the Salt 14.0 manual to the index page.

It also fixes some links to reflect some moves.

It's suprising to have the 14.0 documentation have the general
information. This makes the landing page contain all the information and
redirects the Salt 14.0 manual to the index page.

It also fixes some links to reflect some moves.
@ekohl
Copy link
Member Author

ekohl commented Feb 14, 2024

@maximiliankolb mind having a look at this?

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Is there any way to view a preview of this change?

@ekohl
Copy link
Member Author

ekohl commented Feb 19, 2024

Diff LGTM. Is there any way to view a preview of this change?

https://github.com/theforeman/theforeman.org?tab=readme-ov-file#locally

@maximiliankolb
Copy link
Contributor

LGTM! (assuming the missing icons are a local glitch on my end)

image

@ekohl ekohl merged commit d95c974 into theforeman:gh-pages Feb 19, 2024
2 checks passed
@ekohl ekohl deleted the fix-salt-plugin branch February 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants