Update Puppet Smart-Proxy compatibility #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smart-Proxy compatibility changed in Foreman 3.4 to only support Puppet >=6. I also copied theforeman#2103 to the docs for 3.8 and nightly, which were missing in the original PR.
|
This looks to be mostly the same as #2108 but that's a bit more complete. I also provided references there. Would you mind checking if I made any mistakes there? |
|
@ekohl as already mentioned on IRC, the only main difference I spotted between the PRs is that #2108 marks Puppet 6.x as supported for Foreman 3.7+, while this PR marks them as deprecated (since they are EOL). |
|
I went back on forth on that myself and have had both versions. I think I'll end up with going for deprecated since it's EOL. I'll squash in my notes into the commit message of yours so they're kept in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smart-Proxy compatibility changed in Foreman 3.4 to only support Puppet>=6.
I also copied #2103 to the docs for 3.8 and nightly, which were missing in the original PR.