Allow passing macros to SRPM build #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Aug 30, 2022
| @@ -134,6 +136,10 @@ def main(): | |||
| if scl: | |||
| command += ['--define', 'scl %s' % scl] | |||
|
|
|||
| if macros is not None: | |||
There was a problem hiding this comment.
If the default is {}, is this ever None? I kind of forgot what argument_spec really does.
There was a problem hiding this comment.
If the default is {} then this is never None, no. It's only None for fields that don't have a default and are required=False. (I'd actually would drop the default={} from the argument_spec and keep the if not None here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #318
This aligns better with any provided macros by the project and allows for passing a nightly macro.