Allow ENV variables for urls #936
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimShtein
reviewed
Jan 5, 2025
jeremylenz
force-pushed
the
rem-use-localhost-partha
branch
from
dd2b337 to
ec9ef17
Compare
chris1984
previously approved these changes
Jan 6, 2025
|
Should merge the other one first |
evgeni
reviewed
Jan 9, 2025
jeremylenz
force-pushed
the
rem-use-localhost-partha
branch
from
ec9ef17 to
e6cf395
Compare
|
@evgeni updated 👍 |
jeremylenz
force-pushed
the
rem-use-localhost-partha
branch
from
e6cf395 to
2e10cca
Compare
evgeni
reviewed
Jan 9, 2025
evgeni
reviewed
Jan 10, 2025
jeremylenz
force-pushed
the
rem-use-localhost-partha
branch
2 times, most recently
from
8ce6a8c to
457b108
Compare
parthaa
reviewed
Jan 16, 2025
jeremylenz
dismissed
chris1984’s stale review
more discussions happened later
|
@parthaa are you taking this over? Or otherwise I need to know what to do with it.. |
jeremylenz
force-pushed
the
rem-use-localhost-partha
branch
from
457b108 to
d0965a2
Compare
chris1984
approved these changes
Jan 22, 2025
|
@parthaa do you understand these test failures? I don't.. |
They look transient, kicked it off again. Sometimes you have to do it a few times with this repo. One day we should look at that. |
|
@jeremylenz all 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @parthaa's recommended patch from #932 (comment)
Requires #932