Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on the plugin_manual mechanism in Foreman #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jun 27, 2023

This combines #819 and theforeman/foreman#9756.

@ekohl
Copy link
Member Author

ekohl commented Nov 27, 2023

Rebased to resolve a merge conflict, now ready for review. Still includes #819.

@ekohl
Copy link
Member Author

ekohl commented Apr 26, 2024

Rebased now that 26b5c4a was merged. It's a bit inconsistent that some parts weren't updated to the new docs.

Foreman 3.9 fixed this use and it simplifies the code. The plugin
already requires Foreman >= 3.10.
@ekohl
Copy link
Member Author

ekohl commented Jul 30, 2024

There are 2 places where it's used:

$ rg documentation_button_rex
app/views/job_templates/index.html.erb
5:<% title_actions(documentation_button_rex('3.1JobTemplates'),

app/helpers/remote_execution_helper.rb
57:      documentation_button_rex('3.2ExecutingaJob'),
211:  def documentation_button_rex(section = '')

Given 26b5c4a changed one link to the new documentation, should we align on the new docs instead?

@adamruzicka
Copy link
Contributor

should we align on the new docs instead?

That would be ideal

@ekohl
Copy link
Member Author

ekohl commented Aug 14, 2024

I don't think I'll have time to find out which sections it should link to so I'd prefer to hand it over then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants