Fix rubocop rules #380
Merged
Fix rubocop rules #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archanaserver
force-pushed
the
fix-cops
branch
from
9540773
to
43ff537
Compare
stejskalleos
reviewed
Jan 9, 2024
ekohl
reviewed
Jan 11, 2024
archanaserver
force-pushed
the
fix-cops
branch
from
43ff537
to
6b32066
Compare
12 tasks
ekohl
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Lgtm. You could argue we want to first test Ruby 3, but without the line it'd also install on Ruby 3. I'd go ahead with this but leaving to @stejskalleos for a final approval
|
Thanks @archanaserver @ekohl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.