-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add katello-host-tools for debian/ubuntu #6958
base: deb/develop
Are you sure you want to change the base?
Conversation
I think, I will need help to finish this successfully. |
6c35b23
to
348e297
Compare
[test deb] |
1 similar comment
[test deb] |
348e297
to
7382b64
Compare
I guess, this needs at least theforeman/jenkins-jobs#152 |
That seems like more work. Why do we need to do that? |
We don't require it, but it makes things easier ;) |
Somehow the source needs to be provided. Or should the source just be made avilable via git-annex? Currently I dont know how this can be done in deb build env. |
Do we have a "foreman" org over there or anything, or automation to do the pushing? Trying to avoid having to do that by hand - can you blame me? |
We do have a bot that pushes things, yeah. Things can be arranged ;) |
Take https://github.com/theforeman/obal/blob/master/.github/workflows/release.yml for example. If you push a tag, automation will push it to PyPI. |
[test deb] |
well, it failed, so at least it did try to build something 🙈 |
[test deb] |
now the failure is legit, there is no |
@jturel How do we want to handle this? The "easiest" solution is, to put katello-host-tools on PyPi. Otherwise we need to find another solution to provide the source. |
the other alternative is we implement a kind of "source_url" entry in the build_vars, and make that point at But I would prefer PyPI as it has a rather standardized interface (which we already implement) |
I guess that's OK? I don't have any experience with putting a project there. If one of us does it first, are we able to grant access to others to do so as well? ie I don't want to be the only person who can perform a release to pypi :) |
You can use https://github.com/theforeman/obal/blob/master/.github/workflows/release.yml. It may be better if a GH admin sets the secret for you. I'm not a Katello GH admin so I can't do that. @evgeni? |
I am not an admin either. |
I am but, well, I don't have the password! |
So I added an API token to the project and opened Katello/katello-host-tools#123. While looking at the code I think @sbernhard could you pick up this effort? Edit: or if you don't need |
Well, the files in /bin/* are required and the zypper / apt / yum plugins, too. Actually, I don't know the purpose of setup.py regarding creating a simple tarball. |
Try |
Since there has been no progress on this, I took a stab at this and opened Katello/katello-host-tools#125. That will likely also have packaging consequences, both RPM and deb side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has been released and 4.0.1 should be available on PyPI. Please update the PR to reflect that.
I took a look at the RPM and I realized we don't ship all the additional files (etc, extra) in the tarball on PyPI. That's probably something to address. |
Need Katello/katello-host-tools#130 before we can continue. |
[test deb] |
7b27c5f
to
9be3d67
Compare
9be3d67
to
04e7df3
Compare
04e7df3
to
23ec70b
Compare
I started working on this again in #11027 :) |
No description provided.