Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31022 - Use an isolated Puppet environment #584

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 7, 2020

When there's splay=true in /etc/puppetlabs/puppet/puppet.conf, puppet apply waits a random period (up to 30 minutes). Kafo deals with this by using --config=/tmp/.../puppet.conf which is generated in the ExecutionEnvironment. The boot hook apply_puppet_code does not use this which causes the host's puppet.conf to take effect. This can lead to much longer installer times where it just sleeps.

This patch reuses Kafo::ExecutionEnvironment for an isolated environment.

I have not tested this patch yet, but it's based on https://community.theforeman.org/t/puppet-with-splay-true/20777 as a report.

When there's splay=true in /etc/puppetlabs/puppet/puppet.conf, puppet
apply waits a random period (up to 30 minutes). Kafo deals with this by
using --config=/tmp/.../puppet.conf which is generated in the
ExecutionEnvironment. The boot hook apply_puppet_code does not use this
which causes the host's puppet.conf to take effect. This can lead to
much longer installer times where it just sleeps.

This patch reuses Kafo::ExecutionEnvironment for an isolated
environment.
@ehelms
Copy link
Member

ehelms commented Oct 7, 2020

Generally, this looks like a good change. Since I am working a lot in Kafo code would this be worth while to add to the hook context as a method?

@ekohl
Copy link
Member Author

ekohl commented Oct 7, 2020

Yes, that would be much cleaner. theforeman/kafo#284 would do that. I'm not sure what would be best considering cherry picks so I'm leaving this open for now.

@ekohl
Copy link
Member Author

ekohl commented Oct 7, 2020

#585 for comparison.

@ehelms
Copy link
Member

ehelms commented Oct 12, 2020

@ekohl I am OK with this change as is, if you want to come back later and update it once the Kafo changes have been released.

@ehelms ehelms closed this Sep 7, 2023
@ehelms ehelms reopened this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants