-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework planning for foreman #3634
base: master
Are you sure you want to change the base?
Rework planning for foreman #3634
Conversation
ddf71b1
to
b43f81f
Compare
* Add images for upstream $ git diff master| rg "image::" | rg -v "^@@" | rg -v -- "^-" | cut -c 2- | sed "s@image::common/@guides/common/images/@g" | sed "s/\[.*$//g" * Add xref for ULN content * Hide content for foreman-el+deb * Make images not executable $ chmod -x guides/common/images/* * Render Planning for Foreman for all flavours $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "assembly_" * Reword "on the other hand" to make Vale happy * Reword concepts included in Planning guide $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "modules/" * Split file * Use assembly to bundle provisioning requirements * Verify content in Planning guide for all flavours $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "assembly_" | xargs -I {} cat "{}" | rg "^include" | sed "s/include::/guides\/common\//g" | sed "s/\[.*$//g"
f331cd7
to
4492d57
Compare
@@ -6,7 +6,7 @@ ifdef::satellite[] | |||
You can use Red{nbsp}Hat content as well as custom content and organize it into {Project} products. | |||
endif::[] | |||
ifdef::katello,orcharhino[] | |||
You can use content from Red{nbsp}Hat as well as from Canonical, Oracle, SUSE, and other custom content. | |||
You can use any custom content and content from Red{nbsp}Hat, Canonical, Oracle, and SUSE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I have added these because there's special docs/instructions on how to consume their content:
- Red Hat: -> RH manifest
- Canonical: -> ESM
- Oracle: -> ULN repositories
- SUSE: -> SCC Manager
This is all part of Foreman+Katello docs.
Do you think it's missing a sentence about OS vendor content such as Debian or Rocky Linux? Or maybe refer users to the list of supported Client OS for which default upstream content is always supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this is okay. I'm not sure if it's necessary to mention other content specifically. But it might be worth letting users know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a hell of work, Max!
Some initial thoughts below.
The graphics could use a bit of designer's touch, but I can tackle that later in a follow-up PR.
ifdef::satellite[] | ||
include::common/modules/proc_providing-feedback-on-red-hat-documentation.adoc[leveloffset=+1] | ||
endif::[] | ||
|
||
include::common/modules/con_foreman-overview-and-concepts.adoc[] | ||
|
||
ifdef::katello,satellite,orcharhino[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing endif
below Content and patch management?
There's not much in the foreman-el build right now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a leftover something on the left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Foreman Server & Smart Proxy Servers" -- Foreman Server is not involved, it's only "Smart Proxy servers".
(You might have thought that because Satellite sometimes used to call Capsules "Red Hat Satellite Capsules", but that doesn't mean there's Satellite Server, it's just a silly marketing name leftover.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Foreman Server & Smart Proxy Servers" -- Foreman Server is not involved, it's only "Smart Proxy servers".
@@ -6,7 +6,7 @@ ifdef::satellite[] | |||
You can use Red{nbsp}Hat content as well as custom content and organize it into {Project} products. | |||
endif::[] | |||
ifdef::katello,orcharhino[] | |||
You can use content from Red{nbsp}Hat as well as from Canonical, Oracle, SUSE, and other custom content. | |||
You can use any custom content and content from Red{nbsp}Hat, Canonical, Oracle, and SUSE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this is okay. I'm not sure if it's necessary to mention other content specifically. But it might be worth letting users know.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
guides/common/images/topology-direct-satellite.png
guides/common/images/topology-isolated-satellite.png
guides/common/modules/con_creating-and-managing-roles.adoc
->guides/common/modules/snip_creating-and-managing-roles.adoc
which is now included in twocon_
filesguides/common/modules/ref_overview-of-authentication-methods-in-project.adoc
->guides/common/modules/snip_table-authentication-methods.adoc
which is also included in twocon_
filesTODO
cp && sed
🤞Checklists
no cherry-picks