Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework planning for foreman #3634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 31, 2025

What changes are you introducing?

  • Rework "Planning for Foreman" guide to make it fit for all flavours
  • Add images for upstream

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

  • Show it upstream for all flavours
  • Make content fit for downstream orcharhino

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Requires Remove unnecessary macros #3632
  • Requires Add docs for Oracle ULN content #3639
  • Style-wise, I will try to apply all your feedback.
  • The guide is big: I might create issues for existing technical inaccuracies rather than fixing/retesting everything myself.
  • Created images for upstream for all but two graphics that contain too much information IMHO:
    • guides/common/images/topology-direct-satellite.png
    • guides/common/images/topology-isolated-satellite.png
  • I have split two files that had different headings to snippets and small concept files with correct headings and anchors (diff on GitHub might look weird):
    • guides/common/modules/con_creating-and-managing-roles.adoc -> guides/common/modules/snip_creating-and-managing-roles.adoc which is now included in two con_ files
    • guides/common/modules/ref_overview-of-authentication-methods-in-project.adoc -> guides/common/modules/snip_table-authentication-methods.adoc which is also included in two con_ files

TODO

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

no cherry-picks

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

The PR preview for 4492d57 is available at theforeman-foreman-documentation-preview-pr-3634.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb force-pushed the rework_planning_for_foreman branch 4 times, most recently from ddf71b1 to b43f81f Compare February 5, 2025 14:19
* Add images for upstream
  $ git diff master| rg "image::" | rg -v "^@@" | rg -v -- "^-" | cut -c 2- | sed "s@image::common/@guides/common/images/@g" | sed "s/\[.*$//g"
* Add xref for ULN content
* Hide content for foreman-el+deb
* Make images not executable
  $ chmod -x guides/common/images/*
* Render Planning for Foreman for all flavours
  $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "assembly_"
* Reword "on the other hand" to make Vale happy
* Reword concepts included in Planning guide
  $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "modules/"
* Split file
* Use assembly to bundle provisioning requirements
* Verify content in Planning guide for all flavours
  $ cat guides/doc-Planning_for_Project/master.adoc | rg "^include" | sed "s/include::/guides\//g" | sed "s/\[.*$//g" | rg "assembly_" | xargs -I {} cat "{}" | rg "^include" | sed "s/include::/guides\/common\//g" | sed "s/\[.*$//g"
@maximiliankolb maximiliankolb force-pushed the rework_planning_for_foreman branch from f331cd7 to 4492d57 Compare February 6, 2025 08:15
@@ -6,7 +6,7 @@ ifdef::satellite[]
You can use Red{nbsp}Hat content as well as custom content and organize it into {Project} products.
endif::[]
ifdef::katello,orcharhino[]
You can use content from Red{nbsp}Hat as well as from Canonical, Oracle, SUSE, and other custom content.
You can use any custom content and content from Red{nbsp}Hat, Canonical, Oracle, and SUSE.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have added these because there's special docs/instructions on how to consume their content:

  • Red Hat: -> RH manifest
  • Canonical: -> ESM
  • Oracle: -> ULN repositories
  • SUSE: -> SCC Manager

This is all part of Foreman+Katello docs.

Do you think it's missing a sentence about OS vendor content such as Debian or Rocky Linux? Or maybe refer users to the list of supported Client OS for which default upstream content is always supported?

Copy link
Contributor

@Lennonka Lennonka Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this is okay. I'm not sure if it's necessary to mention other content specifically. But it might be worth letting users know.

@maximiliankolb maximiliankolb marked this pull request as ready for review February 6, 2025 08:23
@aneta-petrova aneta-petrova self-requested a review February 6, 2025 11:45
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a hell of work, Max!
Some initial thoughts below.

The graphics could use a bit of designer's touch, but I can tackle that later in a follow-up PR.

ifdef::satellite[]
include::common/modules/proc_providing-feedback-on-red-hat-documentation.adoc[leveloffset=+1]
endif::[]

include::common/modules/con_foreman-overview-and-concepts.adoc[]

ifdef::katello,satellite,orcharhino[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing endif below Content and patch management?

There's not much in the foreman-el build right now :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a leftover something on the left.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Foreman Server & Smart Proxy Servers" -- Foreman Server is not involved, it's only "Smart Proxy servers".
(You might have thought that because Satellite sometimes used to call Capsules "Red Hat Satellite Capsules", but that doesn't mean there's Satellite Server, it's just a silly marketing name leftover.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Foreman Server & Smart Proxy Servers" -- Foreman Server is not involved, it's only "Smart Proxy servers".

@@ -6,7 +6,7 @@ ifdef::satellite[]
You can use Red{nbsp}Hat content as well as custom content and organize it into {Project} products.
endif::[]
ifdef::katello,orcharhino[]
You can use content from Red{nbsp}Hat as well as from Canonical, Oracle, SUSE, and other custom content.
You can use any custom content and content from Red{nbsp}Hat, Canonical, Oracle, and SUSE.
Copy link
Contributor

@Lennonka Lennonka Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this is okay. I'm not sure if it's necessary to mention other content specifically. But it might be worth letting users know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants