Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document running Ansible roles in diff mode #3613

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Document running Ansible roles in diff mode #3613

wants to merge 3 commits into from

Conversation

rpluem-vf
Copy link

What changes are you introducing?

Documentation for theforeman/foreman_ansible#749

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@rpluem-vf rpluem-vf mentioned this pull request Jan 24, 2025
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

The PR preview for c715450 is available at theforeman-foreman-documentation-preview-pr-3613.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

This was referenced Jan 24, 2025
Open
Open
@maximiliankolb maximiliankolb added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 27, 2025
maximiliankolb
maximiliankolb reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments to align with current style/conventions, rest LGTM. I added the "waiting for code" label.

guides/common/modules/proc_running-ansible-roles-in-diff-mode.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_running-ansible-roles-in-diff-mode.adoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb left review comments

Assignees
No one assigned
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Waiting for code Requires merge of related code in another repository before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpluem-vf @maximiliankolb