Stacklayout: fix CI (on feature/layout-external) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectBase<...>::Release in favor of ::MoveToCHandle
This is a hack, we append imgui_stacklayout.cpp to imgui.cpp. I did not have time to change all the MSVC, android and other build files
|
Thank you, I'm going to integrate your changes |
thedmd
force-pushed
the
feature/layout-external
branch
from
c4a1e42 to
628c1e8
Compare
thedmd
force-pushed
the
feature/layout-external
branch
from
628c1e8 to
e711e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a simple fix that adds two commits:
(void) someIgnoredVar;because the CI complains on thoseSee succesful action run