Support subscription operations #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, good seeing some work done in that direction :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GraphQLite doesn't support
subscriptionoperations at all. However, basic support for the GQL syntax is supported in webonyx. This PR provides basic support for subscriptions.By design, this subscription implementation is basic. After much research and discussion, it's apparent that subscriptions will need to be implemented in a large variety of ways. This implementation is non-opinionated, only replicating the same implementation style as queries and mutations.
What it does, is allow the subscription GQL syntax, routing to the new
#[Subscription]annotated controller method. The behavior will be the same as a mutation or query - no difference there.Future improvements could be made to this to support long-running PHP processes. I'm thinking the controller method could return a generator/fiber.