Add regex rule for failed XML-RPC auth #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: added the filter change to the changelog file, added .vscode to .gitignore and bumped plugin version to 0.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the filter files to include a regex rule for failed XMLRPC authentications. The current regex rules doesn't seem to match simple XMLRPC authentication failures, only multi-call failures.
On my system (Ubuntu 22.04), I could only trigger "XML-RPC authentication failure from " error log, not the "XML-RPC multicall authentication failure from " error log. My reasoning: if no "XML-RPC multicall" warning is being logged, then the regex rule would not apply. Please, let me know if I'm wrong and what is the mistake I'm making (so I can learn and improve!).
If I'm right, this new filter should be enough for the regex to apply. In this case, a mention on the changelog letting people know they need to update their filters would be nice.
PS. Congrats on this nice plugin!