-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add text generation module #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanjoman I think we should try to make the interface a bit more abstract, avoiding exposing the model's implementation details or dependencies to the end user. I'll create a PR with some ideas.
…provements Interface improvements on the Text Generator implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I left a couple of minor notes. There's a class we might not need anymore and we should probably discuss a bit about error handling, but that discussion shouldn't block this PR 😜
No description provided.