Get and delete embeddings space #20
Conversation
|
Missing: Pinecone store unit tests - working on it unless there's another priority |
juanjoman
force-pushed
the
get_delete_embeddings_space
branch
from
89c8bf7
to
0575bbe
Compare
|
|
||
| @RequiredArgsConstructor |
| @Mock | ||
| private EmbeddingsGenerationModel embeddingsGenerationModel; | ||
| @Mock | ||
| private EmbeddingsStore embeddingsStore; | ||
| @InjectMocks | ||
| private EmbeddingsSpaceComponent embeddingsSpaceComponent; | ||
| @Captor | ||
| private ArgumentCaptor<String> sampleTextCaptor; |
...rc/test/java/com/theagilemonkeys/ellmental/embeddingsspace/EmbeddingsSpaceComponentTest.java
Show resolved
Hide resolved
| } |
There was a problem hiding this comment.
Beautiful tests, loved them! So much to learn from them... I'll try to mimic your style in the core abstraction tests once this PR is merged 🚀
| @Data | ||
| public class DeleteVectorSchema { | ||
| private final List<UUID> ids; | ||
| private boolean deleteAll; | ||
| private String namespace; | ||
| private Map<String, String> filterMetadata; | ||
| } |
There was a problem hiding this comment.
It seems that this @Dataannotation serves the same purpose as Java records. What would you consider more idiomatic? I think it could be worth deciding on one or the other and using a unique and consistent style in the whole project 😜
There was a problem hiding this comment.
ooh I just checked and they are almost the same. In this case @DaTa includes @requiredargsconstructor, which creates a constructor only for final properties. For now we just need the list of ids, so we can keep it like it is or create a record that only contains this list for now, what do you think is the best approach? @javiertoledo
Co-authored-by: Javier Toledo <[email protected]>
Co-authored-by: Javier Toledo <[email protected]>
Merge this first -> #16
Fetch Pinecone API -> https://docs.pinecone.io/reference/fetch
Delete Pinecone API -> https://docs.pinecone.io/reference/delete_post