New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with .where method and ranges #94

Merged

esmarkowski merged 1 commit into main from esmarkowski/`where`-keywords-and-ranges

Mar 20, 2024

Member

esmarkowski commented Mar 20, 2024

Was working as expected. range filter works for date ranges and if attribute is a keyword it functions as expected.

Inclusive range forms now adjust the upper bound of the range query:

begin_date = 2.days.ago.beginning_of_day.utc
end_date = 1.day.ago.end_of_day.utc
CrashEvent.where(occurred_on: begin_date..end_date)
# => {filter: [{range: {date: {gte: begin_date, lte: end_date}}}]}

CrashEvent.where(occurred_on: begin_date...end_date)
# => {filter: [{range: {date: {gte: begin_date, lt: end_date}}}]}

Fixes #91


          Inclusive ranges adjust the upper bound condition

d722bdf

Fixes #91

esmarkowski self-assigned this

esmarkowski merged commit 26ce013 into main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet