Fix attribute mapping issues #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes three issues related to attribute mapping in the StretchyModel class. The changes include:
Issue Use attribute options to generate mapping #77: Use attribute options to generate mapping
The mapping definition now works with the Elasticsearch::Repository DSL.
The mapping is set directly using the
mappingmethod.Issue Add keyword fields to text fields by default when using attribute mapping #76: Add keyword fields to text fields by default when using attribute mapping
The default mapping for text fields now includes a keyword field.
The keyword field is automatically generated when no fields option is provided.
Issue Ensure attribute types map to elasticsearch datatypes #75: Ensure attribute types map to Elasticsearch datatypes
The type_for_database method is added to each attribute type.
The mappings method is updated to use the type_for_database method.