Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames the
filter
method tofilter_query
in order to resolve a conflict with the aggregationfilter
and queryfilter
. The necessary changes have been made in the codebase to reflect this renaming. This will improve clarity and avoid confusion in the codebase. Fixes #45In addition it adds
AggregationMethods
that add helpers for named aggregation types.This allows easier composition of aggregations and allows nested aggregations to provided in a comprehensive manner:
Each aggregation method passes it's values to the original
.aggregation
with the name of the aggregation type added as a key, allowing for more concise interface. Fixes #46