Move requires_version_tag? to private #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thor automatically makes all public methods of the generator into commands, which proves to be a problem for mongoid projects, which don't have `ActiveRecord` defined. In those cases running the install generator gives the following error (while it actually manages to generate the initializer: `'requires_version_tag?': uninitialized constant AfterParty::Generators::InstallGenerator::ActiveRecord (NameError)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Thor automatically makes all public methods of the generator into commands, mongoid projects, which don't have
ActiveRecorddefined, get the following error when running theinstallgenerator:'requires_version_tag?': uninitialized constant AfterParty::Generators::InstallGenerator::ActiveRecord (NameError)It does create the initializer, so nothing is really broken, but it's confusing and feels like a bug 🙂