Skip to content

Commit

Permalink
Revert "test: p2p: check that connecting to ourself leads to disconnect"
Browse files Browse the repository at this point in the history
This reverts commit 5d2fb14 and
adds a TODO to add it later again once the race condition is fixed.
  • Loading branch information
theStack committed Jul 1, 2024
1 parent fe70be5 commit 9ec2c53
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions test/functional/p2p_handshake.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
NODE_WITNESS,
)
from test_framework.p2p import P2PInterface
from test_framework.util import p2p_port


# Desirable service flags for outbound non-pruned and pruned peers. Note that
Expand Down Expand Up @@ -89,11 +88,9 @@ def run_test(self):
with node.assert_debug_log([f"feeler connection completed"]):
self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True)

self.log.info("Check that connecting to ourself leads to immediate disconnect")
with node.assert_debug_log(["connected to self", "disconnecting"]):
node_listen_addr = f"127.0.0.1:{p2p_port(0)}"
node.addconnection(node_listen_addr, "outbound-full-relay", self.options.v2transport)
self.wait_until(lambda: len(node.getpeerinfo()) == 0)
# TODO: re-add test introduced in commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000
# ("test: p2p: check that connecting to ourself leads to disconnect") once
# the race condition causing issue #30368 is fixed


if __name__ == '__main__':
Expand Down

0 comments on commit 9ec2c53

Please sign in to comment.