-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings to users when identifier is fuzzy matched #574
Conversation
That's a good idea, actually. |
|
I don't know the appropriate condition for emitting a warning in For example, supplying "Italian" to that function will return the Italian Grand Prix correctly. Based on my reading of the implementation, the We can maybe use Or we can get rid of all whitespaces in the strings first before comparing them. |
Are you interested in figuring that out and changing the fuzzy matching code there to make it work? |
I'm pretty busy the next few days so a thorough investigation with a test suite will have to wait until next weekend at least. I suppose this is not urgent tho and I am happy to take a look at it. |
Actually, with me working on the complete overhaul of the plotting code (to be done soon, hopefully), I'd be happy if I could rebase onto the master with these changes applied. So if you are happy with that, I'd prefer to merge these changes. And then you could make a separate PR for the other changes without any time pressure. |
Sounds good to me |
I think we should issue a warning to users when they provide an invalid input that is fuzzy corrected, just for awareness.