Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data.py #544

Closed
wants to merge 1 commit into from
Closed

Conversation

TracingInsights
Copy link
Contributor

The distance at which each corner is located previously returned NaN and now distance is calculated correctly.

Corner Distance helps to display corner number in speed vs distance and other telemetry plots

@theOehrly
Copy link
Owner

Hi, that's actually intentional. That function isn't intended as public API. You should use Session.get_circuit_info() instead. The corner distance is then calculated from a reference lap.

Why is it done that way? I was advised by the Multiviewer dev to not use their distance info for FastF1 because it might not be accurate because they're calculating it a bit differently. Therefore, FastF1 recalculates the distance data. But that requires a reference lap with reference telemetry.

The function in data.py should probably be prefixed with an underscore to make it clearly private. But there was something about the linter complaining about private imports so I just excluded it from the documentation. Not the cleanest way.

@theOehrly theOehrly closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants