Fix inconsistency in pick_fastest, add deprecation warning for future behavior change #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casper-Guo
commented
Nov 7, 2023
Casper-Guo
force-pushed
the
fix-pick-fastest
branch
from
35a76eb
to
88d6191
Compare
theOehrly
requested changes
Nov 8, 2023
|
I have no idea why or rather how the tests partially failed. But I'm pretty sure that it's not your fault 😅 edit: I mostly figured it out. It's a combination of Ergast being unreliable and GitHub's caching in actions being really annoying sometimes. |
theOehrly
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #472
Handle the uncaught exception. The same empty lap object will be returned regardless of the value of
by_time_only