-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.12 to test #469
Conversation
Python version: 3.11.5 Running this will throw the same
I am not sure why this wasn't caught before by the other tests. The offending JSON is the last one. The
|
Above are all the responses that are processed by this segment. The log is showing the different |
@Casper-Guo thank you for digging into this already. I figured out the reason for this weird behaviour already. The problem is that the data for the Qatar GP is garbage. Somehow, the F1 API lists 8 sessions for this GP. More specifically, the sessions listed at index 2, 4, 6 are not actual sessions. The parser expects exactly five sessions, and the error occurs because the session at index 2 is one of the garbage entries and has no name. Therefore, this is not a bug with Python 3.12, but a general bug that just came up now and is partially masked by caching. |
There are a bunch of deprecation warnings that are new on Python 3.12. Those should be fixed, before adding Python 3.12 to the test matrix. |
Looks like those deprecation warnings are generated for packages that we rely on for datetime processing. I am unsure what needs fixing inside FastF1 just reading the test output |
You're right. I didn't read the log properly. Those warnings can't be fixed in FastF1. Then they should be added to the ignore list in Additionally, please rebase/merge master. I've fixed the event schedule bug caused by the errors in the data for the Qatar GP. |
Ok, passing the tests now |
There were still some warnings. I just pushed the fixed now, because I had it already done when I figured it out. It was just a minor thing. The special characters in the ignore regex need to be escaped. |
Reference: #468