-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strategy example #372
Strategy example #372
Conversation
P.S Doc build check failure is fixed by #368 |
I merged #368, please rebase onto master again. |
f4b9bc9
to
59ad4ae
Compare
I tried running the code and got this. I should have the latest on python, matplotlib, and seaborn
|
This is a bug in FastF1 that was fixed by the PR that we talked above already (#368). It'll work after the next release. |
Ahhh I see thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly the same comments as on the other PR. I made the comments a bit shorter here, no intention to be rude 😅
3bc01ea
to
724ee30
Compare
724ee30
to
0740a12
Compare
Looks good as well. Thank you for adding these three very helpful examples! (And I'll get around to your other open PR and discussions soon now.) |
You are welcome! Being able to contribute to a project that I use a ton really is a joy. I will try to work on some of the visuals in #325 in the future; there are several that I want to learn to make. In the meantime, I am more than glad to investigate any other good visualizations you find as well. |
I think something like this would be cool as well. There's no example yet, that really utilizes this information. So it's nice to show that this data is available. |
File running correctly also depends on #368. The following plot is generated:
Note that the drivers ideally will appear in descending order by finishing position. This is the behaviour seen in similar functions in the past. Some basic investigation shows that the drivers do not appear in
session.laps
in sorted finishing order. This may be a bug.