Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summarised_competencies CI issues #366

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix summarised_competencies CI issues #366

merged 4 commits into from
Oct 8, 2024

Conversation

MakisH
Copy link
Collaborator

@MakisH MakisH commented Oct 8, 2024

In the summarized_competencies.md:

  • Removes the duplicate commented-out list of authors (the comment needs to be in YAML anyway)
  • Replaces "University of Würzburg" with https://github.com/the-teachingRSE-project as affiliation.
  • Fix an assertion regarding the initials not appearing in the acknowledgments list (replaces it with We, renders normally)
  • Update the .gitignore

Motivated by the CI failing for the pull request #362 (not for the branch, but for the merged result).

@MakisH MakisH requested review from knarrff and CaptainSifff October 8, 2024 07:46
@MakisH MakisH self-assigned this Oct 8, 2024
@MakisH MakisH changed the title Fix summarized_competencies CI issues Fix summarised_competencies CI issues Oct 8, 2024
@MakisH MakisH mentioned this pull request Oct 8, 2024
Copy link
Collaborator

@CaptainSifff CaptainSifff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up!

@CaptainSifff CaptainSifff merged commit 55209e3 into main Oct 8, 2024
5 checks passed
@MakisH MakisH deleted the fix-ci branch October 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants