Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Prevent Paperless crash when consume folder is unavailable #629

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

w0ndersp00n
Copy link

When the consume folder for paperless is on a network drive, and that location is (temporary) unavailable, then the consumer in docker crashes. The only way to resume is by manually restarting the container.

This small addition catches the error and prevents the consumer from crashing. The cosumer resumes it's duties after the location is available again.

@tido-
Copy link
Contributor

tido- commented Jun 12, 2020

2 approving reviews - can some one from the core team please have a look, I mean the checks are fine?

Is anybody still out there or is the project dead, just like the parrot?

@MasterofJOKers
Copy link
Contributor

Shouldn't it crash here, too? Or basically anywhere it tries to access any file on the network drive later on or do the other functions all catch the occurring exceptions?

@w0ndersp00n
Copy link
Author

I haven't experienced a crash at that location. Furthermore, it never gets there, since my addition prevents that.

@tido-
Copy link
Contributor

tido- commented Jul 18, 2020

@MasterofJOKers & @pitkley any chance to get this merged this weekend?

@tido-
Copy link
Contributor

tido- commented Jul 24, 2020

@BastianPoe , any chance you support this merge?

@BastianPoe
Copy link
Contributor

Looks good to me - but I am no admin and hence cannot approve the PR.

@tido-
Copy link
Contributor

tido- commented Jul 24, 2020 via email

@tido-
Copy link
Contributor

tido- commented Jul 24, 2020

@danielquinn in #470 you say you try to get PR merged, but as of now we get double-PRs because you didn't merge. Can you please:

  1. Merge Make consumer create target directories #652 because this should also solve this PR (629) :) two-in-one
  2. Can you please edit your post and put in names who can approve and merge?

Thank you and sorry to bother.

Cheers
Tido

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants