Sort package arguments in Dockerfile #509
Conversation
|
Guys, thanks for those reviews. But why isn't travis reporting anything? |
|
@bebehei it is probably related to the recent move to an organization. I have informed Daniel about it. |
|
Sorry about this guys. I'm having trouble with Travis (*why can't we all just use GitLab?) and haven't been able to figure out what the problem is. Details are in #512. I'll get it up & running as soon as I can. |
This applies the Dockerfile best practices from dockerhub. Also it adds `--no-cache` to the `apk add` calls. This has got the same effect like `apk update`, but doesn't store the package lists in the container.
|
So, I made a force push now. It's building fine now. |
|
Well, Travis status reports are fucked up again. Interestingly Travis builds the PR's commits, but it doesn't report the commit's status. Build for 557d730. |
| install: | ||
| - true | ||
| script: | ||
| - docker build -t paperless . |
There was a problem hiding this comment.
should we include a --pull here to get the latest and greates base image?
docker build --pull -t paperless .
|
Travis hasn't got any images preloaded. So it doesn't matter, the image will get pulled anyway |
|
I am going to close and reopen this PR, since that seems to fix Travis (thanks for discovering this easy fix, @stgarf 👍). |
|
So guys, will you finally merge this now? |
|
@bebehei Looks like as soon as it has two "approved" reviews it will be merged. There was an issue with Travis not running CI on in-progress PRs during "The Great Paperless Organization Migration of 2019™" that's been mostly resolved as of today. |
|
Thanks @stgarf for going through all these older and held-up issues. I don't have any experience running with Docker, so I'll have to leave this review to someone else. |
This applies the Dockerfile best practices from dockerhub.
Also it adds
--no-cacheto theapk addcalls. This has got the same effectlike
apk update, but doesn't store the package lists in the container.