Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect incorrect subtypes of interface fields across subgraphs #64

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

kamilkisiela
Copy link
Member

@kamilkisiela kamilkisiela commented Jun 25, 2024

  • cover a case when interface field expects an interface (or union) and the field of an object type implementing the interface resolves a member.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/federation-composition 0.11.4-alpha-20240626090339-ff88a56 npm ↗︎ unpkg ↗︎

@kamilkisiela kamilkisiela merged commit 9ec8078 into main Jun 26, 2024
4 checks passed
@kamilkisiela kamilkisiela deleted the kamil-subtypes branch June 26, 2024 09:11
kamilkisiela pushed a commit that referenced this pull request Jun 26, 2024
# Releases
## @theguild/[email protected]

### Patch Changes

- [#64](#64)
[`9ec8078`](9ec8078)
Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - fix: detect
incorrect subtypes of interface fields across subgraphs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant